lkml.org 
[lkml]   [2011]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: 2.6.38-rc1: arp triggers RTNL assertion
    From
    From: Eric Dumazet <eric.dumazet@gmail.com>
    Date: Mon, 24 Jan 2011 22:11:38 +0100

    > Le vendredi 21 janvier 2011 à 13:06 -0800, David Miller a écrit :
    >> From: Eric Dumazet <eric.dumazet@gmail.com>
    >> Date: Fri, 21 Jan 2011 19:52:56 +0100
    >>
    >> > Here is how I fixed this, thanks again Jamie !
    >> >
    >> > [PATCH] net: neighbour: pneigh_lookup() doesnt need RTNL
    >>
    >> Eric, I don't think we can do this.
    >>
    >> Fundamentally, any time a user operation changes the configuration
    >> of the networking, we must hold the RTNL.
    >>
    >> Eliding the RTNL for lookups is fine, but for things that change
    >> state it is not.
    >>
    >> I therefore think you'll need to rework the arp_ioctl() portions
    >> of the commit that introduced this regression.
    >>
    >
    > Here is a second try of the fix, thanks !
    >
    > Note : Tested with CONFIG_PROVE_RCU=y
    >
    > [PATCH] net: arp_ioctl() must hold RTNL

    Thanks Eric, this one looks a lot better. I'll apply this later
    tonight.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-01-24 22:15    [W:0.020 / U:2.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site