lkml.org 
[lkml]   [2011]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/12] perf: Carve out mmap helpers for general use
    On Fri, Jan 21, 2011 at 12:29:37PM -0500, Arnaldo Carvalho de Melo wrote:
    > Em Fri, Jan 21, 2011 at 04:09:31PM +0100, Borislav Petkov escreveu:
    > > From: Borislav Petkov <borislav.petkov@amd.com>
    > >
    > > Export the mmap_read* helpers into tools/lib/perf/mmap.[ch]
    >
    > Borislav, can you take a look at:
    >
    > http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=shortlog;h=refs/heads/perf/core
    >
    > More specifically take a look at the function test__basic_mmap in:
    >
    > http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=blob;f=tools/perf/builtin-test.c;h=f03798a298b00b328a11f06ce20cc352d123ec28;hb=refs/heads/perf/core
    >
    > 434 /*
    > 435 * This test will generate random numbers of calls to some getpid syscalls,
    > 436 * then establish an mmap for a group of events that are created to monitor
    > 437 * the syscalls.
    > 438 *
    > 439 * It will receive the events, using mmap, use its PERF_SAMPLE_ID generated
    > 440 * sample.id field to map back to its respective perf_evsel instance.
    > 441 *
    > 442 * Then it checks if the number of syscalls reported as perf events by
    > 443 * the kernel corresponds to the number of syscalls made.
    > 444 */

    Ok, I see at least one problem with my patch - you've reworked the
    mmaping functionality in evlist.c/evsel.c and I should use it too, I
    guess. For that, I think you'd want me to apply my stuff ontop of your
    perf/core branch, right?

    Am I missing something else?

    Thanks.

    --
    Regards/Gruss,
    Boris.

    Advanced Micro Devices GmbH
    Einsteinring 24, 85609 Dornach
    General Managers: Alberto Bozzo, Andrew Bowd
    Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
    Registergericht Muenchen, HRB Nr. 43632


    \
     
     \ /
      Last update: 2011-01-24 10:03    [W:0.023 / U:0.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site