[lkml]   [2011]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 10/10] fs: make aio plug
Jens Axboe <> writes:

>>> @@ -1698,6 +1701,7 @@ long do_io_submit(aio_context_t ctx_id, long nr,
>>> if (ret)
>>> break;
>>> }
>>> + blk_finish_plug(&plug);
>>> aio_batch_free(batch_hash);
>> I'm pretty sure you want blk_finish_plug to run after aio_batch_free.
> You mean to cover the iput()? That's not a bad idea, if that ends up
> writing it out. I did a few read tests here and confirmed it's sending
> down batches of whatever number is submitted.

No, I actually didn't make it all the way through 5/10, so I didn't
realize you got rid of the blk_run_address_space. I agree with the TODO
item to get rid of the aio batching, since it's now taken care of with
the on-stack plugging.

As for the iput, I don't think you will get the final iput here, since
you've just scheduled I/O against the file.


 \ /
  Last update: 2011-01-24 20:19    [W:0.095 / U:10.988 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site