lkml.org 
[lkml]   [2011]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/7] x86, microcode, AMD: Remove unneeded memset call
    Date
    From: Borislav Petkov <borislav.petkov@amd.com>

    collect_cpu_info_amd() clears its csig arg but this is done in the
    microcode_core's collect_cpu_info() by clearing the embedding struct
    ucode_cpu_info. Drop it.

    Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
    Acked-by: Andreas Herrmann <Andreas.Herrmann3@amd.com>
    ---
    arch/x86/kernel/microcode_amd.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
    index 8b58fc1..274fa40 100644
    --- a/arch/x86/kernel/microcode_amd.c
    +++ b/arch/x86/kernel/microcode_amd.c
    @@ -77,7 +77,6 @@ static int collect_cpu_info_amd(int cpu, struct cpu_signature *csig)
    struct cpuinfo_x86 *c = &cpu_data(cpu);
    u32 dummy;

    - memset(csig, 0, sizeof(*csig));
    if (c->x86_vendor != X86_VENDOR_AMD || c->x86 < 0x10) {
    pr_warning("microcode: CPU%d: AMD CPU family 0x%x not "
    "supported\n", cpu, c->x86);
    --
    1.7.4.rc2


    \
     
     \ /
      Last update: 2011-01-24 16:29    [W:0.018 / U:32.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site