lkml.org 
[lkml]   [2011]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/7] x86, microcode: Correct sysdev_add error path
    Date
    From: Borislav Petkov <borislav.petkov@amd.com>

    When we encounter an error while initting the microcode driver on a CPU,
    we must undo the previously added sysfs group.

    Cc: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
    Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
    Acked-by: Andreas Herrmann <Andreas.Herrmann3@amd.com>
    ---
    arch/x86/kernel/microcode_core.c | 6 ++++--
    1 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c
    index 1cca374..87af68e 100644
    --- a/arch/x86/kernel/microcode_core.c
    +++ b/arch/x86/kernel/microcode_core.c
    @@ -417,8 +417,10 @@ static int mc_sysdev_add(struct sys_device *sys_dev)
    if (err)
    return err;

    - if (microcode_init_cpu(cpu) == UCODE_ERROR)
    - err = -EINVAL;
    + if (microcode_init_cpu(cpu) == UCODE_ERROR) {
    + sysfs_remove_group(&sys_dev->kobj, &mc_attr_group);
    + return -EINVAL;
    + }

    return err;
    }
    --
    1.7.4.rc2


    \
     
     \ /
      Last update: 2011-01-24 16:29    [W:0.019 / U:32.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site