[lkml]   [2011]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] sched: fix autogroup nice tune on UP
On Sun, Jan 23, 2011 at 11:16 PM, Pekka Enberg <> wrote:
>> tg->se->load, the reason is update_cfs_shares()
>> do nothing on SMP.
> Typo here? You mean UP, right?

Ah, Yeah. Thanks for pointing it.

> I'm not an expert on the scheduler but this looks like the wrong thing
> to do. Shouldn't you fix update_cfs_shares() to work on UP properly?

I have through about that. No-poking on update_cfs_shares() is because
update_cfs_shares() is called at several hot path, like enqueue_entity()/
dequeue_entity(), but it doesn't make sense on UP.

But I guess you are right. We still need to update the load of cfs_rq
after update_load_set() is called even on UP, so
update_cfs_shares() is the suitable place to do that.

Will take another look at update_cfs_shares().


Only stand for myself

 \ /
  Last update: 2011-01-24 04:19    [W:0.052 / U:1.576 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site