lkml.org 
[lkml]   [2011]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix uninitialized variable use in mm/memcontrol.c::mem_cgroup_move_parent()
On Sat, 22 Jan 2011 20:51:32 +0100 (CET)
Jesper Juhl <jj@chaosbits.net> wrote:

> In mm/memcontrol.c::mem_cgroup_move_parent() there's a path that jumps to
> the 'put_back' label
> ret = __mem_cgroup_try_charge(NULL, gfp_mask, &parent, false, charge);
> if (ret || !parent)
> goto put_back;
> where we'll
> if (charge > PAGE_SIZE)
> compound_unlock_irqrestore(page, flags);
> but, we have not assigned anything to 'flags' at this point, nor have we
> called 'compound_lock_irqsave()' (which is what sets 'flags').
> So, I believe the 'put_back' label should be moved below the call to
> compound_unlock_irqrestore() as per this patch.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Thank you.

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Andrew, I'll move my new patces onto this. So, please pick this one 1st.



\
 
 \ /
  Last update: 2011-01-24 01:17    [W:0.040 / U:2.196 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site