lkml.org 
[lkml]   [2011]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/1] Use cachable mapping for i915 opregion.
Date
On Sunday, January 23, 2011, Chris Wilson wrote:
> On Sun, 23 Jan 2011 18:23:34 +0100, Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de> wrote:
> > The opregion is a shared memory region between ACPI and the graphics
> > driver. As the ACPI mapping has been changed to cachable in commit
> > 6d5bbf00d251cc73223a71422d69e069dc2e0b8d, mapping the intel opregion
> > non-cachable now fails. As no bus-master hardware is involved in the
> > opregion, cachable map should do no harm.
>
> Satisfied myself that is indeed equivalent to use the newly introduced
> acpi_os_ioremap for this purpose and applied to -fixes.

However, it might be better to use acpi_os_ioremap() in case we decide to
go back to ioremap() for some reason. For now, ioremap_cache() seems fine,
but ...

Thanks,
Rafael


\
 
 \ /
  Last update: 2011-01-23 21:55    [W:0.058 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site