Messages in this thread | | | Date | Sat, 22 Jan 2011 23:09:56 +0900 (JST) | Subject | Re: NILFS crash on 2.6.37 | From | Ryusuke Konishi <> |
| |
On Fri, 21 Jan 2011 20:57:48 -0500, Wakko Warner wrote: > Ryusuke Konishi wrote: > > On Fri, 21 Jan 2011 16:37:38 +0900 (JST), Ryusuke Konishi wrote: > > > (Cc'ed to linux-nilfs) > > Does the following patch fix your problem? > > > diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c > > index 0994f6a7..58fd707 100644 > > --- a/fs/nilfs2/super.c > > +++ b/fs/nilfs2/super.c > > @@ -704,7 +704,8 @@ skip_mount_setup: > > sbp[0]->s_state = > > cpu_to_le16(le16_to_cpu(sbp[0]->s_state) & ~NILFS_VALID_FS); > > /* synchronize sbp[1] with sbp[0] */ > > - memcpy(sbp[1], sbp[0], nilfs->ns_sbsize); > > + if (sbp[1]) > > + memcpy(sbp[1], sbp[0], nilfs->ns_sbsize); > > return nilfs_commit_super(sbi, NILFS_SB_COMMIT_ALL); > > } > > That patch fix it. Just a note, the 2.6.37 vanilla source was about 20 > lines up from 704
Thanks for testing. Will send upstream and to stable.
> > > > [ 1202.581501] NILFS warning: broken superblock. using spare superblock. > > > > [ 1202.582093] NILFS warning: broken superblock. using spare superblock. > > Why does it say this 2 times? Just curious.
Because each super block is read twice in different block sizes.
Well, indeed it looks confusing. I'll try to do something.
Ryusuke Konishi
| |