[lkml]   [2011]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH v5 01/27] kvm: stop including asm-generic/bitops/le.h directly
    asm-generic/bitops/le.h is only intended to be included directly from
    asm-generic/bitops/ext2-non-atomic.h or asm-generic/bitops/minix-le.h
    which implements generic ext2 or minix bit operations.

    This stops including asm-generic/bitops/le.h directly and use ext2
    non-atomic bit operations instead.

    It seems odd to use ext2_set_bit() on kvm, but it will replaced with
    __set_bit_le() after introducing little endian bit operations
    for all architectures. This indirect step is necessary to maintain
    bisectability for some architectures which have their own little-endian
    bit operations.

    Signed-off-by: Akinobu Mita <>
    Cc: Avi Kivity <>
    Cc: Marcelo Tosatti <>

    Change from v4:
    - splitted into two patches to fix a bisection hole

    The whole series is available in the git branch at:
    git:// le-bitops-v5

    virt/kvm/kvm_main.c | 3 +--
    1 files changed, 1 insertions(+), 2 deletions(-)

    diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
    index f29abeb..3461001 100644
    --- a/virt/kvm/kvm_main.c
    +++ b/virt/kvm/kvm_main.c
    @@ -52,7 +52,6 @@
    #include <asm/io.h>
    #include <asm/uaccess.h>
    #include <asm/pgtable.h>
    -#include <asm-generic/bitops/le.h>

    #include "coalesced_mmio.h"
    #include "async_pf.h"
    @@ -1421,7 +1420,7 @@ void mark_page_dirty_in_slot(struct kvm *kvm, struct kvm_memory_slot *memslot,
    if (memslot && memslot->dirty_bitmap) {
    unsigned long rel_gfn = gfn - memslot->base_gfn;

    - generic___set_le_bit(rel_gfn, memslot->dirty_bitmap);
    + ext2_set_bit(rel_gfn, memslot->dirty_bitmap);


     \ /
      Last update: 2011-01-22 14:15    [W:0.022 / U:50.592 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site