Messages in this thread | | | Date | Sun, 23 Jan 2011 10:15:28 +0800 | From | Gui Jianfeng <> | Subject | Re: [PATCH 2/6 v3] cfq-iosched: Introduce cfq_entity for CFQ group |
| |
Vivek Goyal wrote: > On Mon, Dec 27, 2010 at 04:50:51PM +0800, Gui Jianfeng wrote: > > [..] >> -static struct cfq_group *cfq_rb_first_group(struct cfq_rb_root *root) >> +static struct cfq_entity *cfq_rb_first_entity(struct cfq_rb_root *root) >> { >> if (!root->left) >> root->left = rb_first(&root->rb); >> >> if (root->left) >> - return rb_entry_cfqg(root->left); >> + return rb_entry_entity(root->left); >> > > Why are we defining cfq_rb_first_entity(). Can't we simply use cfq_rb_first() > as introduced in first patch.
Vivek,
At this time, we can't remove cfq_rb_first_entity(), because we don't use st->count for cfqg. In [PATCH 5/6], I remove cfq_rb_first_entity() and just use cfq_rb_first() for cfqq and cfqg.
Thanks, Gui
> > Thanks > Vivek >
| |