lkml.org 
[lkml]   [2011]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/3] mmc: add per device quirk placeholder
    On Sun, Jan 9, 2011 at 6:26 PM, Pierre Tardy <tardyp@gmail.com> wrote:
    > From: Pierre Tardy <pierre.tardy@intel.com>
    >
    > Some cards have quirks valid for every platforms
    > using current platform quirk hooks leads to a lot
    > of code and debug duplication.
    >
    > So we inspire a bit from what exists in PCI subsystem
    > and do our own per vendorid/deviceid quirk
    > We still drop the complexity of the pci quirk system
    > (with special section tables, and so on)
    > That can be added later if needed.

    I like this.

    It's exactly what we need for the wl12xx, so thanks for pushing this.

    I'm not sure about the necessity of the function hooks though - it
    just looks like complexity that we don't really need, and I would
    rather have this framework directly set the required quirks like USB
    is doing. I do see the benefit it provides you with the gating
    framework and the SDIO set/unset issue, and I don't have a cleaner
    alternative approach, so I guess we can live with it.

    Acked-by: Ohad Ben-Cohen <ohad@wizery.com>


    \
     
     \ /
      Last update: 2011-01-22 23:57    [W:0.021 / U:30.788 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site