lkml.org 
[lkml]   [2011]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/7] Nexus One Support
From
Date
Hi Ted,

On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker <dwalker@codeaurora.org> wrote:
> > > I'll add this list into the commit text ..

On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote:
> > So why is everyone bitching at Daniel when he's doing something the
> > Android folks should have done themselves a long time ago?

On Fri, 2011-01-21 at 18:49 -0500, Ted Ts'o wrote:
> Two wrongs don't make a right. And it's not like not submitting
> changes is wrong, although granted it's not ideal. (I'd say removing
> attribution from a git commit is even worse. If you're doing the
> equivalent of a cherry pick, you should preserve the Author field.
> Even if you're doing some cleanup work, as the maintainer I generally
> preserve the Author line, and will simply add the fact that I did some
> cleanup to the commit body. The question is who did more work; the
> person who originally submitted the code, or the person who did the
> cleanup.)

Sure, it would have been nicer for everyone involved if Daniel would
have kept the original patches and added new patches to clean it up on
top of that to preserve the history. However, I don't understand the
harsh comments when this looks like a honest mistake! And I especially
don't understand the almost hostile attitude of the Android developers
who have been sitting on these patches for over a year now AFAICT.

Pekka



\
 
 \ /
  Last update: 2011-01-22 09:23    [from the cache]
©2003-2011 Jasper Spaans