Messages in this thread | | | Date | Fri, 21 Jan 2011 15:40:35 +0900 | Subject | Re: [PATCH 3/7] remove putback_lru_pages() in hugepage migration context | From | Minchan Kim <> |
| |
Hello,
On Fri, Jan 21, 2011 at 3:28 PM, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote: > This putback_lru_pages() is inserted at cf608ac19c to allow > memory compaction to count the number of migration failed pages. > > But we should not do it for a hugepage because page->lru of a hugepage > is used differently from that of a normal page: > > in-use hugepage : page->lru is unlinked, > free hugepage : page->lru is linked to the free hugepage list, > > so putting back hugepages to LRU lists collapses this rule. > We just drop this change (without any impact on memory compaction.) > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > Cc: Minchan Kim <minchan.kim@gmail.com>
As I said previously, It seems mistake during patch merge. I didn't add it in my original patch. You can see my final patch. https://lkml.org/lkml/2010/8/24/248
Anyway, I realized it recently so I sent the patch to Andrew. Could you see this one? https://lkml.org/lkml/2011/1/20/241
Thanks for notice me.
-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |