lkml.org 
[lkml]   [2011]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] RFC: abstract access to xtime_lock into a set of inline functions
On Thu, Jan 20, 2011 at 12:30:29PM -0500, Christoph Hellwig wrote:
> On Thu, Jan 20, 2011 at 06:14:08PM +0100, Torben Hohn wrote:
> > the -rt patches change the xtime_lock to a raw_seqlock_t
> > so a pretty huge portion of the patch deals with changing
> > the locking functions.
> >
> > this commit uses inline functions, to hide the type
> > of the lock.
>
> That's not how kernel code usually works.
>
> > - write_seqlock(&xtime_lock);
> > + xtime_write_seqlock();
> > do_timer(1);
> > - write_sequnlock(&xtime_lock);
> > + xtime_write_sequnlock();
>
> However there's a pretty clear pattern of taking xtime_lock, calling
> do_timer and then releasing. A useful thing you could do is to rename
> do_timer to do_timer_locked and make do_timer take and release
> xtime_lock in one place.

How about adding raw_seqlock just like what we have done for
spinlock? Thus xtime_lock can be defined to raw_seqlock and
others can also benefit from the raw_seqlock like xtime_lock.

Thanks,
Yong


\
 
 \ /
  Last update: 2011-01-21 14:27    [W:0.091 / U:8.068 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site