lkml.org 
[lkml]   [2011]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call
    From
    Date
    Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.

    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    ---
    drivers/video/pxa168fb.c | 6 +-----
    1 files changed, 1 insertions(+), 5 deletions(-)

    diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
    index cea6403..35f61dd 100644
    --- a/drivers/video/pxa168fb.c
    +++ b/drivers/video/pxa168fb.c
    @@ -701,16 +701,12 @@ static int __devinit pxa168fb_probe(struct platform_device *pdev)
    */
    pxa168fb_init_mode(info, mi);

    - ret = pxa168fb_check_var(&info->var, info);
    - if (ret)
    - goto failed_free_fbmem;
    -
    /*
    * Fill in sane defaults.
    */
    ret = pxa168fb_check_var(&info->var, info);
    if (ret)
    - goto failed;
    + goto failed_free_fbmem;

    /*
    * enable controller clock
    --
    1.7.0.4




    \
     
     \ /
      Last update: 2011-01-21 12:21    [W:0.022 / U:239.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site