Messages in this thread | | | Date | Fri, 21 Jan 2011 14:14:55 +0300 | From | Sergei Shtylyov <> | Subject | Re: [PATCH v4 3/5] MIPS/Perf-events: Fix event check in validate_event() |
| |
Hello.
On 21-01-2011 11:19, Deng-Cheng Zhu wrote:
> Ignore events that are in off/error state or belong to a different PMU.
> This patch originates from the following commit for ARM by Will Deacon:
> - 65b4711ff513767341aa1915c822de6ec0de65cb > ARM: 6352/1: perf: fix event validation
> The validate_event function in the ARM perf events backend has the > following problems:
> 1.) Events that are disabled count towards the cost. > 2.) Events associated with other PMUs [for example, software events or > breakpoints] do not count towards the cost, but do fail validation, > causing the group to fail.
> This patch changes validate_event so that it ignores events in the > PERF_EVENT_STATE_OFF state or that are scheduled for other PMUs.
> Changes: > v4 - v3: > o None > v3 - v2: > o Keep all mentioned commits in the form of number + title + original > summary + (MIPS specific info when needed). > v2 - v1: > o Corrected the return value of the event check in validate_event().
The patch changes should follow the --- tearline, not precede it.
> Acked-by: Will Deacon<will.deacon@arm.com> > Acked-by: David Daney<ddaney@caviumnetworks.com> > Signed-off-by: Deng-Cheng Zhu<dengcheng.zhu@gmail.com> > ---
WBR, Sergei
| |