lkml.org 
[lkml]   [2011]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Checkpatch problem with Kconfig help symbol ?
On Fri, Jan 21, 2011 at 09:19:31AM +0200, Tapio Vihuri wrote:
> On Thu, 2011-01-20 at 10:38 +0100, ext Michal Marek wrote:
> > On 20.1.2011 09:06, WANG Cong wrote:
> > > On Wed, 19 Jan 2011 14:42:48 +0200, Tapio Vihuri wrote:
> > >
> > >> Hi
> > >>
> > >> Is this false positive ?
> > >>
> > >> WARNING: please write a paragraph that describes the config symbol fully
> > >> #60: FILE: drivers/input/misc/Kconfig:159: + help
> > >>
> > >>
> > >> Interesting enough, also:
> > >>
> > >> ./scripts/checkpatch.pl --file drivers/input/misc/Kconfig WARNING:
> > >> please write a paragraph that describes the config symbol fully #430:
> > >> FILE: input/misc/Kconfig:430:
> > >> + help
> > >>
> > >>
> > >> But this is different line.
> > >>
> > >
> > > Seems yes, the Kconfig part of your patch looks fine.
> >
> > The check is complaining that the help text is too short:
> >
> > +config ECI_CTRL_DEBUG
> > + bool "ECI controller debug"
> > + depends on INPUT_ECI_AT20
> > + help
> > + Say Y here to enable debugging messages for ECI controller driver.
> >
> > Michal
>
> Hi.
>
> That I suspect, and I tried to add four lines more.
> But it still complain the same.

If you have a patch which has four or more lines and trips this message
it is false yes. Please do send me your example, as my current tests
pass.

-apw


\
 
 \ /
  Last update: 2011-01-21 11:21    [W:0.063 / U:0.868 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site