lkml.org 
[lkml]   [2011]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] memcg: fix rmdir, force_empty with THP
>> > @@ -2278,17 +2287,23 @@ static int mem_cgroup_move_parent(struct
>> > goto out;
>> > if (isolate_lru_page(page))
>> > goto put;
>> > + /* The page is isolated from LRU and we have no race with splitting */
>> > + charge = PAGE_SIZE << compound_order(page);
>>
>> Why is LRU isolation preventing the splitting?
>>
Oops! It seems that this comment made me confuse 'split' and 'collapse'.
Yes, it's 'collapse', not 'split', that is prevented by isolation.

> I use compound_lock now. I'll post clean up.
>
I'll wait for your patch.

Thanks,
Daisuke Nishimura.


\
 
 \ /
  Last update: 2011-01-21 01:31    [W:0.015 / U:5.860 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site