Messages in this thread | | | Date | Fri, 21 Jan 2011 09:16:32 +0900 | Subject | Re: [PATCH] mfd: Staticise non-exported symbols in MAX8998 driver | From | Kyungmin Park <> |
| |
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
On Fri, Jan 21, 2011 at 6:47 AM, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > No need to have them in the global namespace and sparse complains. > > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > --- > drivers/mfd/max8998.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c > index bbfe867..c002142 100644 > --- a/drivers/mfd/max8998.c > +++ b/drivers/mfd/max8998.c > @@ -233,7 +233,7 @@ struct max8998_reg_dump { > u8 val; > }; > #define SAVE_ITEM(x) { .addr = (x), .val = 0x0, } > -struct max8998_reg_dump max8998_dump[] = { > +static struct max8998_reg_dump max8998_dump[] = { > SAVE_ITEM(MAX8998_REG_IRQM1), > SAVE_ITEM(MAX8998_REG_IRQM2), > SAVE_ITEM(MAX8998_REG_IRQM3), > @@ -298,7 +298,7 @@ static int max8998_restore(struct device *dev) > return 0; > } > > -const struct dev_pm_ops max8998_pm = { > +static const struct dev_pm_ops max8998_pm = { > .suspend = max8998_suspend, > .resume = max8998_resume, > .freeze = max8998_freeze, > -- > 1.7.2.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |