lkml.org 
[lkml]   [2011]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7] input: tegra-kbc - Add tegra keyboard driver
On Thu, Jan 20, 2011 at 12:51:09PM +0530, Trilok Soni wrote:
> Hi Rakesh,
>
> On 1/20/2011 6:41 AM, riyer@nvidia.com wrote:
> > From: Rakesh Iyer <riyer@nvidia.com>
> >
> > This patch adds support for the internal matrix keyboard controller for
> > Nvidia Tegra platforms.
> >
> > Signed-off-by: Rakesh Iyer <riyer@nvidia.com>
> > ---
> > Fixed the stupid loop variable change.
> > Fixed some code styling problems reported by checkpatch.pl.
> >
>
> Thanks a ton for creating quick revisions :)
>
> > arch/arm/mach-tegra/include/mach/kbc.h | 61 +++
> > drivers/input/keyboard/Kconfig | 10 +
> > drivers/input/keyboard/Makefile | 1 +
> > drivers/input/keyboard/tegra-kbc.c | 727 ++++++++++++++++++++++++++++++++
> > 4 files changed, 799 insertions(+), 0 deletions(-)
> > create mode 100644 arch/arm/mach-tegra/include/mach/kbc.h
> > create mode 100644 drivers/input/keyboard/tegra-kbc.c
> >
> > diff --git a/arch/arm/mach-tegra/include/mach/kbc.h b/arch/arm/mach-tegra/include/mach/kbc.h
> > new file mode 100644
> > index 0000000..60d646c
> > --- /dev/null
> > +++ b/arch/arm/mach-tegra/include/mach/kbc.h
> > @@ -0,0 +1,61 @@
> > +/*
> > + * Platform definitions for tegra-kbc keyboard input driver
> > + *
> > + * Copyright (c) 2010, NVIDIA Corporation.
>
> Wearing my legal hat. You might want to do 2010-2011 ?

OK, Rakesh, if you want copyright adjusted please shout and I can fix it
up locally.

Trilok, I understand you are happy, right? Can I put you down as
reviewed-by?

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2011-01-20 08:33    [W:0.060 / U:2.632 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site