[lkml]   [2011]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [GIT] Networking
    On Thu, Jan 20, 2011 at 2:38 PM, Colin Walters <> wrote:
    > It is actually; see src/gs-auth-pam.c; there is some pretty scary code
    > there; basically all of PAM is put in a thread to avoid blocking the
    > mainloop.  Whether the code is actually buggy I can't say immediately;
    > it's certainly possible.

    I stand corrected.

    But it turns out to be a kernel bug after all, although not in
    networking. It bisected down to commit e462c448fdc8: "pipe: use event
    aware wakeups".

    I don't immediately see why, but I suspect it's the pipe_release()
    case that needs to add POLLHUP to the wakeup cases. I suspect that
    what is going on is that gnome-screensaver-dialog uses a pipe to talk
    to the PAM code, and waits for the pipe to close. And we used to wake
    it up unconditionally, but now we only wake up the poll waiter if it's
    waiting for POLLIN/POLLOUT, rather than for anything else.

    Anyway, I'll double-check my bisect by doing a revert of that commit
    on top of current -git, but I'm pretty sure the bisect was correct,
    since it did end up pointing to a commit that clearly changed poll

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-01-21 00:47    [W:0.020 / U:20.292 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site