[lkml]   [2011]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] leds: Convert bd2802 driver to dev_pm_ops
On Thu, Jan 20, 2011 at 03:12:01PM -0800, Andrew Morton wrote:


To be honest I've been forming the opinion that this is just cruft these
days - it's hard to see a modern Linux system where you're sufficiently
space constrained to want to turn it off without also being sufficiently
power constrained to want to turn it on and it's hassle to maintain it.
That said...

> It would be nice to fix all this via automagic within the
> SIMPLE_DEV_PM_OPS() implementation but I can't see a way of doing that :(

...the problem here is that the macro is doing roughly the right magic
but the original driver wasn't ifdefing the suspend and resume stuff at
all. If the were only defining the suspend and resume functions under
CONFIG_PM_SLEEP it should build cleanly. Since the original driver
didn't have the ifdefs I didn't add or update them.

This means the pm_ops can be unconditionally defined which seems to be
the preferred idiom for this stuff. If SIMPLE_DEV_PM_OPS() didn't do
the stuff it's doing then the warnings would vanish in the same way they
did originally, by virtue of the functions being unconditionally
referenced from the vtable.

 \ /
  Last update: 2011-01-21 00:27    [W:0.061 / U:2.968 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site