lkml.org 
[lkml]   [2011]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig
On Tue, Jan 18, 2011 at 12:58:48AM +0530, K, Narendra wrote:
> On Sat, Jan 15, 2011 at 02:39:49AM +0530, Stephen Rothwell wrote:
> > Hi Narendra,
> >
> > On Fri, 14 Jan 2011 20:52:42 +0530 <Narendra_K@Dell.com> wrote:
> > >
> > > This patch addresses the build failure described in this thread by
> > > compiling fs/nls/nls_base.c always into vmlinux, thus making the base
> > > nls functions available always.
> >
> > Even on platforms that don't support ACPI or DMI ...
> >
> > You should really restrict this to CONFIG_ACPI || CONFIG_DMI ||
> > CONFIG_NLS ... maybe create a CONFIG_NLS_BASE that is selected by ACPI,
> > DMI and NLS?
>
> Hi Stephen,
>
> Thank you for the suggestions.
>
> I agree with your suggestion that we should compile nls_base.o
> conditionally, only when ACPI || DMI || NLS. I have introduced a bew
> config option CONFIG_NLS_BASE and made ACPI, DMI and NLS select it.
>
> V1 -> V2:
>
> 1. Conditionally compile fs/nls/nls_base.c by introducing a new config
> option CONFIG_NLS_BASE, which is selected by (ACPI || DMI || NLS).
> Behavior of the rest of the files under fs/nls is not changed.
>
> From: Narendra K <narendra_k@dell.com>
> Subject: [PATCH V2] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig

Hi,

Please let me know if there are any concerns with Version 2 of the patch.
If it looks good please consider it for inclusion.

With regards,
Narendra K


\
 
 \ /
  Last update: 2011-01-20 19:47    [W:0.101 / U:0.376 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site