lkml.org 
[lkml]   [2011]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] dmi-scan: Use little-endian for the first 3 fields of the UUID.

Hi Bjorn,

On Wed, 19 Jan 2011 12:01:02 -0700, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote :

> On Wednesday, January 19, 2011 10:54:11 am Anisse Astier wrote:
> >
> > From: Pascal VITOUX <pascal@substantiel.fr>
> >
> > - Get SMBIOS version.
> > - Byte-swap the first 3 fields of the UUID (DMI type 1) as off SMBIOS
> > version 2.6.
> >
> > This patch is an adaptation of Jean Delvare patches for dmidecode
> > rev1.100, rev1.01 and rev1.119.
> > http://cvs.savannah.gnu.org/viewvc/dmidecode/dmidecode.c?root=dmidecode&view=log
> >
> > It is intended to get the same uuid from dmidecode tool as from sysfs kernel
> > tree, more compliant with SMBIOS specification.
> > Therefore this patch will have the kernel return a different UUID if you
> > are using a recent BIOS implementing SMBIOS >= 2.6.
>
> It seems like a good idea to have /sys/class/dmi/id/product_uuid
> match what dmidecode reports. Does dmidecode use the same algorithm
> (testing dmi_ver against 0x0206)?
Yes, it does.

>
> It'd be nice to mention that /sys/... filename explicitly in the
> changelog, and maybe even include an example from a system where
> they previously did not match, and now do.
Indeed.

>
> I don't have an opinion on the SMBIOS version stuff, but that looks
> like it should be split into a separate patch.
It seems it's wrong anyway and will need more patch splitting (see Jean
Delvare's email).

Thanks for the review,

Anisse



\
 
 \ /
  Last update: 2011-01-20 18:13    [W:0.089 / U:10.844 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site