lkml.org 
[lkml]   [2011]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] lockdep: move early boot local IRQ enable/disable status to init/main.c
    On Thu, Jan 20, 2011 at 12:23:51PM +0100, Peter Zijlstra wrote:
    > On Thu, 2011-01-20 at 12:11 +0100, Tejun Heo wrote:
    > > Hello, guys.
    > >
    > > These two patches remove both warnings. The first warning was
    > > completely spurious. The second lockdep one was triggered by
    > > on_each_cpu() enabling local IRQ too early.
    > >
    > > I don't think percpu allocator itself malfunctioned. There was no
    > > allocation failure. It whines when percpu allocation fails but didn't
    > > in the log. Other than calling vfree() early triggering the above
    > > condition, it worked okay.
    > >
    > > So, it's either the early enabling of local IRQ by on_each_cpu()
    > > breaking something in the IRQ subsystem or something different. Ingo,
    > > can you please see whether these two patches cure the panic too?
    >
    > Why not use something like: system_state != SYSTEM_RUNNING ?

    Cuz, it's finer grained than that. We can add a SYSTEM_* flag but I
    wasn't sure whether that would be just creating more noise. If we try
    to consolidate these things, we probably should consider
    oops_in_progress too. It probably is a good idea but let's first fix
    the problem at hand.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2011-01-20 12:29    [W:0.021 / U:30.852 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site