[lkml]   [2011]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] drm/i915: Dont kick-off hangcheck after a DRI interrupt
On Thu, 20 Jan 2011 21:10:10 +1100, Herbert Xu <> wrote:
> While the current kernel tree has indeed changed from 2.6.36,
> I don't think this is the spot corresponding to my crash.
> My spot was in hangcheck_elapsed and as far as I can see it will
> crash in the current kernel in pretty much the same way. In
> particular, i915_hangcheck_ring_idle will probably crash on all
> three rings.

Except that i915_hangcheck_elapsed should not be called from DRI code
paths, the whole error recovery code only works with GEM (we can't recover
the hardware if it is being poked directly by "userspace").

> FWIW after adding the INIT_LIST_HEAD to the init_dri function
> my kernel hasn't crashed yet (a couple of hours and counting).

Ah, yes. Need to pull some more code in from init_ringbuffer.

For my sanity can you check that the above patch also prevents the crash?
I'd rather not install a timer, and execute undesirable code paths, if we
don't need one.

Chris Wilson, Intel Open Source Technology Centre

 \ /
  Last update: 2011-01-20 12:03    [W:0.045 / U:0.708 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site