lkml.org 
[lkml]   [2011]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 105/260] i915: return -EFAULT if copy_to_user fails
    Date
    From: Dan Carpenter <error27@gmail.com>

    commit c877cdce93a44eea96f6cf7fc04be7d0372db2be upstream.

    copy_to_user() returns the number of bytes remaining to be copied and
    I'm pretty sure we want to return a negative error code here.

    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/gpu/drm/i915/i915_gem.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
    index 37a9ea3..e07722a 100644
    --- a/drivers/gpu/drm/i915/i915_gem.c
    +++ b/drivers/gpu/drm/i915/i915_gem.c
    @@ -3818,6 +3818,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
    if (ret != 0) {
    DRM_ERROR("copy %d cliprects failed: %d\n",
    args->num_cliprects, ret);
    + ret = -EFAULT;
    goto pre_mutex_err;
    }
    }
    --
    1.7.3.3


    \
     
     \ /
      Last update: 2011-01-02 08:59    [W:0.018 / U:31.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site