Messages in this thread | | | Date | Tue, 18 Jan 2011 21:23:24 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v5] input: tegra-kbc - Add tegra keyboard driver |
| |
On Tue, Jan 18, 2011 at 07:28:29PM -0800, Rakesh Iyer wrote: > Sorry for the late response as I was not working on it on Monday. > > The patch as is did not work. I am debugging this currently.
Sorry about that. If you describe the effects you are seeing I might try to think where I messed up.
> > Once I find a fix, can I resend all the driver code as one patch file? > I will include your 2nd patch in it as well.
Sure.
> > Secondly, the driver is a platform driver for Tegra platforms. The > platform code needs some of the #defines to be present in kbc.h, so > you will see some of the defines moved back to kbc.h from tegra-kbc.c >
I only moved KBC_MAX_COL, KBC_MAX_ROW and KBC_MAX_KEY since they are not needed in keymaps expressed via struct matrix_keypad_data. But if they are needed for something else that's fine.
-- Dmitry
| |