lkml.org 
[lkml]   [2011]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] serial: msm: Add support for UARTDM cores
On 1/19/2011 2:24 PM, Russell King - ARM Linux wrote:
> On Wed, Jan 19, 2011 at 02:08:29PM -0800, Stepan Moskovchenko wrote:
>>>> + /* Mask conditions we're ignorning. */
>>>> + sr&= port->read_status_mask;
>>>> + if (sr& UART_SR_RX_BREAK)
>>>> + flag = TTY_BREAK;
>>>> + else if (sr& UART_SR_PAR_FRAME_ERR)
>>>> + flag = TTY_FRAME;
>>> It doesn't look like the flag is used anywhere after it has been
>>> assigned.
>> An artifact of an old driver. Removed.
> But still required to support proper error signalling.
>

On second thought, from poking around the kernel some more, I believe
the following should be a better approach:
if (sr & UART_SR_RX_BREAK) {
tty_insert_flip_char(tty, 0, TTY_BREAK);
} else if (sr & UART_SR_PAR_FRAME_ERR) {
tty_insert_flip_char(tty, 0, TTY_FRAME);
}

Russell, what do you think? Shall I make the change in v2?

Thanks
Steve

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.



\
 
 \ /
  Last update: 2011-01-20 03:41    [W:1.310 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site