lkml.org 
[lkml]   [2011]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] input: tegra-kbc - Add tegra keyboard driver
On Wed, Jan 19, 2011 at 02:30:07PM -0800, riyer@nvidia.com wrote:
> +
> +static void tegra_kbc_report_keys(struct tegra_kbc *kbc)
> +{
> + unsigned char scancodes[KBC_MAX_KPENT];
> + unsigned short keycodes[KBC_MAX_KPENT];
> + u32 val = 0;
> + unsigned int i;
> + unsigned int num_down = 0;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&kbc->lock, flags);
> + for (i = 0; i < KBC_MAX_KPENT * 4; i++) {

This will cause going beyond scancodes[] and keycodes[] and stomping on
your stack...

--
Dmitry


\
 
 \ /
  Last update: 2011-01-20 00:01    [W:0.133 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site