lkml.org 
[lkml]   [2011]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] trusted-keys: small cleanup
From
Date
On Tue, 2011-01-18 at 10:39 +0900, Tetsuo Handa wrote:
> Mimi Zohar wrote:
> > Change the existing '(!ret)' to '(ret < 0)', like the rest of the code?
> > It's not wrong, but ....
>
> Something like this?

Actually, I was only asking for a one line change in the patch.

> > va_end(argp);
> > - ret = crypto_shash_final(&sdesc->shash, paramdigest);
> > + if (!ret)
> > + ret = crypto_shash_final(&sdesc->shash, paramdigest);
> > if (!ret)

Change the second '(!ret)' here, the crypto_shash_file() return code
test, from '(!ret)' to '(ret < 0)', like the other crypto_shash_file()
tests.

Thanks!

Mimi



\
 
 \ /
  Last update: 2011-01-18 10:29    [W:0.065 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site