lkml.org 
[lkml]   [2011]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] trusted-keys: check for NULL before using it
    On Mon, 17 Jan 2011, Tetsuo Handa wrote:

    > >From 8118c3d0d6f2b291d56e2f4475f2aa5156299cf3 Mon Sep 17 00:00:00 2001
    > From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    > Date: Mon, 17 Jan 2011 09:25:34 +0900
    > Subject: [PATCH 2/3] trusted-keys: check for NULL before using it
    >
    > TSS_rawhmac() checks for data != NULL before using it.
    > We should do the same thing for TSS_authhmac().
    >
    > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    > ---
    > security/keys/trusted_defined.c | 5 +++++
    > 1 files changed, 5 insertions(+), 0 deletions(-)
    >
    > diff --git a/security/keys/trusted_defined.c b/security/keys/trusted_defined.c
    > index 7b21795..f7d0677 100644
    > --- a/security/keys/trusted_defined.c
    > +++ b/security/keys/trusted_defined.c
    > @@ -148,6 +148,11 @@ static int TSS_authhmac(unsigned char *digest, const unsigned char *key,
    > if (dlen == 0)
    > break;
    > data = va_arg(argp, unsigned char *);
    > + if (!data) {
    > + ret = -EINVAL;
    > + va_end(argp);
    > + goto out;
    > + }
    > ret = crypto_shash_update(&sdesc->shash, data, dlen);
    > if (ret < 0) {
    > va_end(argp);
    >
    Looks good to me..

    Reviewed-by: Jesper Juhl <jj@chaosbits.net>


    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
    Plain text mails only, please.



    \
     
     \ /
      Last update: 2011-01-17 19:37    [W:0.031 / U:61.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site