lkml.org 
[lkml]   [2011]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -perf/perf/core 4/6] perf: Add strfilter for general purpose string filter
    (2011/01/17 21:55), Arnaldo Carvalho de Melo wrote:
    > Em Mon, Jan 17, 2011 at 10:40:29AM -0200, Arnaldo Carvalho de Melo escreveu:
    >> Em Thu, Jan 13, 2011 at 09:46:17PM +0900, Masami Hiramatsu escreveu:
    >>> Add strfilter for general purpose string filter.
    >>> Every filter rules are descrived by glob matching pattern
    >>> and '!' prefix which means Logical NOT.
    >>> A strfilter consists of those filter rules connected
    >>> with '&' and '|'. A set of rules can be folded by using
    >>> '(' and ')'. It also accepts spaces around rules and those
    >>
    >> You're not checking strfilter__alloc results, I'm fixing this for you
    >> this time :-)
    >
    > Not really, please check strdup() result and strfilter__delete() needs
    > to traverse all the nodes, not just the ones pointed at the root, right?

    Would you mean that it should release all the node including
    ascendants? Hmm, I think we might just need to update its parent
    so that it doesn't get affected, because the strfilter__delete()
    doesn't know which user variable points the parent of the given node.
    E.g. If we remove "b*" from "(a* | b*)", just update it as "(a* | !*)"

    > Please address these problems and resubmit this patch, I merged the
    > first three, folding the documentation one you sent for --funcs into the
    > third, where the feature was added.
    >
    > Please rebase from my perf/core branch at:
    >
    > http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=shortlog;h=refs/heads/perf/core
    >

    Yeah, anyway, I'll update it for fixing the misses you pointed.

    Thanks!


    > - Arnaldo
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/


    --
    Masami HIRAMATSU
    2nd Dept. Linux Technology Center
    Hitachi, Ltd., Systems Development Laboratory
    E-mail: masami.hiramatsu.pt@hitachi.com


    \
     
     \ /
      Last update: 2011-01-17 17:43    [W:2.645 / U:1.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site