[lkml]   [2011]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH -perf/perf/core 4/6] perf: Add strfilter for general purpose string filter
Em Mon, Jan 17, 2011 at 10:40:29AM -0200, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Jan 13, 2011 at 09:46:17PM +0900, Masami Hiramatsu escreveu:
> > Add strfilter for general purpose string filter.
> > Every filter rules are descrived by glob matching pattern
> > and '!' prefix which means Logical NOT.
> > A strfilter consists of those filter rules connected
> > with '&' and '|'. A set of rules can be folded by using
> > '(' and ')'. It also accepts spaces around rules and those
> You're not checking strfilter__alloc results, I'm fixing this for you
> this time :-)

Not really, please check strdup() result and strfilter__delete() needs
to traverse all the nodes, not just the ones pointed at the root, right?

Please address these problems and resubmit this patch, I merged the
first three, folding the documentation one you sent for --funcs into the
third, where the feature was added.

Please rebase from my perf/core branch at:;a=shortlog;h=refs/heads/perf/core

- Arnaldo

 \ /
  Last update: 2011-01-17 13:59    [W:0.135 / U:0.556 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site