Messages in this thread Patch in this message | | | From | Shawn Bohrer <> | Subject | [PATCH 3/3] epoll: remove unnecessary test of ep->ovflist for available events | Date | Sat, 15 Jan 2011 11:00:37 -0600 |
| |
The additional test for ep->ovflist != EP_UNACTIVE_PTR to signify available events was added in 5071f97ec6d74f006072de0ce89b67c8792fe5a1 but doesn't appear to do anything. Either this is a bug or the check isn't needed.
If the ep->ovflist is not EP_UNACTIVE_PTR then ep_send_events() calls ep_scan_ready_list() which sets ep->ovflist = NULL thus loosing any events which may have been stored there.
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com> --- fs/eventpoll.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 57a77f5..afeb78c 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -1180,7 +1180,7 @@ retry: } skip: /* Is it worth to try to dig for events ? */ - eavail = !list_empty(&ep->rdllist) || ep->ovflist != EP_UNACTIVE_PTR; + eavail = !list_empty(&ep->rdllist); spin_unlock_irqrestore(&ep->lock, flags); -- 1.7.3.4
| |