lkml.org 
[lkml]   [2011]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH 2/2] power_supply: Add new LED trigger charging-blink-solid-full
Date
On Friday 14 January 2011 18:18:51 Anton Vorontsov wrote:

> Strange, I got neither 0/2 nor 1/2.

Hmm, patches are definitely on ML, here's link to 1st patch on patchwork:
https://patchwork.kernel.org/patch/464481/

However, if you want, I can forward copy of 0/2 and 1/2 to you directly, but
check your 'spam' folder first ;)

> Anyway, I'm fine with this particular patch, but to take 1/2 via
> battery-2.6.git I need Richard's Acked-by tag.

Ok

> > + led_trigger_blink(psy->charging_blink_full_solid_trig,
> > + &delay_on, &delay_off);
>
> I think it's better to allow passing NULL to led_trigger_blink()
> and thus avoid delay_{on,off} dummy variables.

It mimics led_blink_set function, and I prefer to keep it this way (just to
keep consistency), or change led_blink_set behavior.

Regards
Vasily


\
 
 \ /
  Last update: 2011-01-14 17:41    [W:0.596 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site