lkml.org 
[lkml]   [2011]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH option A 2/2] PCI: do not create quirk I/O regions below PCIBIOS_MIN_IO
    Date
    Some broken BIOSes on ICH4 chipset report an ACPI region which is in
    conflict with legacy IDE ports when ACPI is disabled. Even though the
    regions overlap, IDE ports are working correctly (we cannot find out
    the decoding rules on chipsets).

    So the only problem is the reported region itself, if we don't reserve
    the region in the quirk everything works as expected.

    This patch avoids reserving any quirk regions below PCIBIOS_MIN_IO
    which is 0x1000. Some regions might be (and are by a fast google
    query) below this border, but the only difference is that they won't
    be reserved anymore. They should still work though the same as before.

    The conflicts look like (1f.0 is bridge, 1f.1 is IDE ctrl):
    pci 0000:00:1f.1: address space collision: [io 0x0170-0x0177] conflicts with 0000:00:1f.0 [io 0x0100-0x017f]

    At 0x0100 a 128 bytes long ACPI region is reported in the quirk for
    ICH4. ata_piix then fails to find disks because the IDE legacy ports
    are zeroed:
    ata_piix 0000:00:1f.1: device not available (can't reserve [io 0x0000-0x0007])

    References: https://bugzilla.novell.com/show_bug.cgi?id=558740
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
    Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Thomas Renninger <trenn@suse.de>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    ---
    drivers/pci/quirks.c | 9 ++++++++-
    1 files changed, 8 insertions(+), 1 deletions(-)

    diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
    index 8db2426..cfedf2b 100644
    --- a/drivers/pci/quirks.c
    +++ b/drivers/pci/quirks.c
    @@ -388,7 +388,14 @@ static void __devinit quirk_io_region(struct pci_dev *dev, unsigned region,
    unsigned size, int nr, const char *name)
    {
    region &= ~(size-1);
    - if (region) {
    + /*
    + * The check for PCIBIOS_MIN_IO is to ensure we won't create a conflict
    + * with low legacy (and fixed) ports. We don't know the decoding
    + * priority and can't tell whether the legacy device or the one created
    + * here is really at that address. This happens on boards with broken
    + * BIOSes. At least one known is with ICH4.
    + */
    + if (region && region >= PCIBIOS_MIN_IO) {
    struct pci_bus_region bus_region;
    struct resource *res = dev->resource + nr;

    --
    1.7.3.4



    \
     
     \ /
      Last update: 2011-01-14 11:35    [W:3.902 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site