lkml.org 
[lkml]   [2011]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/16] x86: Always use x86_cpu_to_logical_apicid for cpu -> logical apic id
On Wed, Jan 12, 2011 at 06:40:09PM -0800, David Rientjes wrote:
> On Thu, 30 Dec 2010, Tejun Heo wrote:
>
> > diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> > index ba78b1e..8ad231c 100644
> > --- a/arch/x86/kernel/apic/apic.c
> > +++ b/arch/x86/kernel/apic/apic.c
> > @@ -1252,6 +1252,14 @@ void __cpuinit setup_local_APIC(void)
> > */
> > apic->init_apic_ldr();
> >
> > +#ifdef CONFIG_X86_32
> > + /*
> > + * APIC LDR is initialized. Fetch and store logical_apic_id.
> > + */
> > + early_per_cpu(x86_cpu_to_logical_apicid, cpu) =
> > + logical_smp_processor_id();
> > +#endif
> > +
> > /*
> > * Set Task Priority to 'accept all'. We never change this
> > * later on.
>
> You can remove the initialization of x86_cpu_to_logical_apicid in the
> ->init_apic_ldr() callback in x2apic_cluster.c now too?

Believe it or not, that's a different variable. And yeah we probably
should clean that up too.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-01-13 11:59    [W:0.062 / U:29.312 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site