[lkml]   [2011]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: vfs-scale, d_revalidate from nfsd
    On Fri, Jan 14, 2011 at 02:12:35PM +1100, Nick Piggin wrote:
    > The main idea here would be to just pass in a flags parameter rather
    > thank poking in nd to get the rcu-walk status. That would solve this
    > problem and also avoid nd for most filesystems that don't care about
    > it.

    Start with nd->flags getting passed explicitly, and be ready to see
    * call on the final stage of open split away and folded with
    ->lookup() and ->open()/->creat()
    * the rest of callers to lose nd completely.
    That's what's going to happen in the next cycle.

    BTW, why on the earth do you have that:
    static int xattr_hide_revalidate(struct dentry *dentry, struct nameidata *nd)
    if (nd->flags & LOOKUP_RCU)
    return -ECHILD;
    return -EPERM;
    when the sole intent of that sucker is to have dentry of /.xattr (pinned
    in dcache and hashed all along) rejected on lookups from root? IOW, WTF
    bother with -ECHILD here at all?

     \ /
      Last update: 2011-01-14 04:23    [W:0.044 / U:7.948 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site