lkml.org 
[lkml]   [2011]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] strncpy() will not \0 terminate result
On Thu, 13 Jan 2011, Wolfram Sang wrote:

> On Thu, Jan 13, 2011 at 11:35:39PM +0100, Jesper Juhl wrote:
> > Hi,
> >
> > Mpass() in scripts/unifdef.c has this code:
> > strncpy(keyword, "if ", 4);
> > this will fail to \0 terminate the destination.
> > Following patch should fix that up.
> >
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
>
> Thanks for fixing those issues. If you could spend a few more seconds on the
> subject line (missing sth like "scripts/unifdef"-prefix; I initially was
> fearing the bug was in lib/string.c) and the commit-message (which reads like a
> mail), that would be helpful for reviewers.
>
Yeah, I don't know what happened when I wrote that subject - it's quite
bad. Sorry.

--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.



\
 
 \ /
  Last update: 2011-01-13 23:51    [W:0.807 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site