Messages in this thread | | | Date | Thu, 13 Jan 2011 23:48:35 +0100 (CET) | From | Jesper Juhl <> | Subject | Re: [PATCH] strncpy() will not \0 terminate result |
| |
On Thu, 13 Jan 2011, Wolfram Sang wrote:
> On Thu, Jan 13, 2011 at 11:35:39PM +0100, Jesper Juhl wrote: > > Hi, > > > > Mpass() in scripts/unifdef.c has this code: > > strncpy(keyword, "if ", 4); > > this will fail to \0 terminate the destination. > > Following patch should fix that up. > > > > Signed-off-by: Jesper Juhl <jj@chaosbits.net> > > Thanks for fixing those issues. If you could spend a few more seconds on the > subject line (missing sth like "scripts/unifdef"-prefix; I initially was > fearing the bug was in lib/string.c) and the commit-message (which reads like a > mail), that would be helpful for reviewers. > Yeah, I don't know what happened when I wrote that subject - it's quite bad. Sorry.
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please.
| |