lkml.org 
[lkml]   [2011]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] Rename struct task variables from p to tsk
    From
    On Thu, Jan 13, 2011 at 12:19 AM, Eric B Munson <emunson@mgebm.net> wrote:
    > p is not a meaningful identifier, this patch replaces all instances
    > in page_alloc.c of p when used as a struct task with the more useful
    > tsk.
    >

    Yesterday, Andrew raise an eyebrow about that.
    His simple lookup found below.

    --

    On Tue, 11 Jan 2011 13:03:22 -0800 (PST)
    Hugh Dickins <hughd@google.com> wrote:
    > On Tue, 11 Jan 2011, Andrew Morton wrote:
    < snip >
    > > Oh, and since when did we use `p' to identify task_structs?
    >
    > Tsk, tsk: we've been using `p' for task_structs for years and years!

    Only bad people do that. "p". Really?

    z:/usr/src/linux-2.6.37> grep -r " \*p;" . | wc -l
    2329
    z:/usr/src/linux-2.6.37> grep -r "task_struct \*p" . | wc -l
    824

    bah.

    --

    How about cleaning up everything in this chance?




    --
    Kind regards,
    Minchan Kim


    \
     
     \ /
      Last update: 2011-01-13 00:17    [W:0.032 / U:30.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site