lkml.org 
[lkml]   [2011]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRe: [git pull] drm intel only fixes
    On Wed, Jan 12, 2011 at 11:46 AM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
    >
    > Since I doubt we're actually offloading to our video decode kernels for
    > Flash video on your machine

    It's the latest 64-bit beta flash player, so maybe it does use hw acceleration.


    > it could very well be a memory bw issue.
    > Can you try this small patch to see if one of the low power watermarks
    > is giving you trouble (note: cut & pasted)?

    No difference.

    > It could also be the normal power watermarks though too; you could just
    > make plane-wm and cursor_wm higher to test that.

    I multiplied them by two, no difference. The patch I used attached.

    Does nobody else see this?

    Linus
    drivers/gpu/drm/i915/intel_display.c | 4 ++++
    1 files changed, 4 insertions(+), 0 deletions(-)

    diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
    index 25d9688..2ea1a51 100644
    --- a/drivers/gpu/drm/i915/intel_display.c
    +++ b/drivers/gpu/drm/i915/intel_display.c
    @@ -3445,6 +3445,7 @@ static bool ironlake_compute_wm0(struct drm_device *dev,
    entries += tlb_miss;
    entries = DIV_ROUND_UP(entries, display->cacheline_size);
    *plane_wm = entries + display->guard_size;
    +*plane_wm *=2;
    if (*plane_wm > (int)display->max_wm)
    *plane_wm = display->max_wm;

    @@ -3457,6 +3458,7 @@ static bool ironlake_compute_wm0(struct drm_device *dev,
    entries += tlb_miss;
    entries = DIV_ROUND_UP(entries, cursor->cacheline_size);
    *cursor_wm = entries + cursor->guard_size;
    +*cursor_wm *= 2;
    if (*cursor_wm > (int)cursor->max_wm)
    *cursor_wm = (int)cursor->max_wm;

    @@ -3607,6 +3609,8 @@ static void ironlake_update_wm(struct drm_device *dev,
    if (enabled != 1)
    return;

    +return;
    +
    clock = planea_clock ? planea_clock : planeb_clock;

    /* WM1 */
    \
     
     \ /
      Last update: 2011-01-12 21:31    [W:0.023 / U:1.832 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site