lkml.org 
[lkml]   [2011]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] scatterlist: new helper functions
On Wed, 12 Jan 2011 04:52:29 +0200 Maxim Levitsky wrote:


> > > /**
> > > - * sg_compare_to_buffer - compare contents of the data pointeted by sg table
> > > + * sg_compare_to_buffer - compare contents of the data covered by an sg table
> > > * to a kernel ram buffer
> > > - * @sg - the current sg entry
> > > - * @buffer - linear buffer to compare with
> > > - * @len - lenght of that buffer
> > > + * @sg: the current sg entry
> > > + * @buffer: linear buffer to compare with
> > > + * @len: length of that buffer
> >
> > Returns what??
> 0 if equal and 1 otherwise.
> Was too lazy to implement full strcmp compliance.
> Is that needed?

Not that I know of, just what the function returns was needed.


> All very fair comments.
> Will check everything once again.
> Thanks for a review!
>
> Best regards,
> Maxim Levitsky
>
> --

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***


\
 
 \ /
  Last update: 2011-01-12 07:43    [W:0.053 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site