lkml.org 
[lkml]   [2011]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sound: constify functions in ac97
At Wed, 12 Jan 2011 14:44:07 +0200,
Alexey Dobriyan wrote:
>
> On Wed, Jan 12, 2011 at 1:03 PM, Hanno Böck <hanno@hboeck.de> wrote:
> >  struct snd_ac97_build_ops {
> > -       int (*build_3d) (struct snd_ac97 *ac97);
> > -       int (*build_specific) (struct snd_ac97 *ac97);
> > -       int (*build_spdif) (struct snd_ac97 *ac97);
> > -       int (*build_post_spdif) (struct snd_ac97 *ac97);
> > +       int (* const build_3d) (struct snd_ac97 *ac97);
> > +       int (* const build_specific) (struct snd_ac97 *ac97);
> > +       int (* const build_spdif) (struct snd_ac97 *ac97);
> > +       int (* const build_post_spdif) (struct snd_ac97 *ac97);
> >  #ifdef CONFIG_PM
> > -       void (*suspend) (struct snd_ac97 *ac97);
> > -       void (*resume) (struct snd_ac97 *ac97);
> > +       void (* const suspend) (struct snd_ac97 *ac97);
> > +       void (* const resume) (struct snd_ac97 *ac97);
> >  #endif
> > -       void (*update_jacks) (struct snd_ac97 *ac97);   /* for jack-sharing */
> > +       /* for jack-sharing */
> > +       void (* const update_jacks) (struct snd_ac97 *ac97);
>
> Can we please not do this.
>
> You made whole ops structure RO, this is enough.

Yes. Hanno, could you fix and resubmit?


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-01-12 18:05    [W:0.825 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site