lkml.org 
[lkml]   [2011]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/2] memcg: remove unnecessary BUG_ON
Date
Now memcg in unmap_and_move checks BUG_ON of charge.
mem_cgroup_prepare_migration returns either 0 or -ENOMEM.
If it returns -ENOMEM, it jumps out unlock without the check.
If it returns 0, it can pass BUG_ON. So it's meaningless.
Let's remove it.

Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
mm/migrate.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index b8a32da..8f0f131 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -667,7 +667,6 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private,
rc = -ENOMEM;
goto unlock;
}
- BUG_ON(charge);

if (PageWriteback(page)) {
if (!force || !sync)
--
1.7.0.4


\
 
 \ /
  Last update: 2011-01-11 09:53    [W:0.045 / U:8.676 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site