lkml.org 
[lkml]   [2011]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] mm: add replace_page_cache_page() function
On Tue, 11 Jan 2011 23:25:28 +0900
Minchan Kim <minchan.kim@gmail.com> wrote:

> On Tue, Jan 11, 2011 at 03:07:54PM +0100, Miklos Szeredi wrote:
> > (resent with fixed CC list, sorry for the duplicate)
> >
> > Thanks for the review.
> >
> > Here's an updated patch. Modifications since the last post:
> >
> > - don't pass gfp_mask (since it's only able to deal with GFP_KERNEL
> > anyway)
> >
>
> I am not sure it's a good idea.
> Now if we need just GFP_KERNEL, we can't make sure it in future.
> Sometime we might need GFP_ATOMIC and friendd functions
> (ex, add_to_page_cache_lru,add_to_page_cache_locked) already have gfp_mask.
> It's a exported function so it's hard to modify it in future.
>
> I want to keep it.
> Instead of removing it, we can change mem_cgroup_prepare_migration as
> getting gfp_mask.
>
you're right.

Thanks,
-Kame



\
 
 \ /
  Last update: 2011-01-12 01:53    [W:0.047 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site