lkml.org 
[lkml]   [2011]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2] hid-multitouch: changes from the review process
    From
    On Tue, Jan 11, 2011 at 6:35 PM, Henrik Rydberg <rydberg@bitmath.org> wrote:
    > On Tue, Jan 11, 2011 at 04:45:54PM +0100, Benjamin Tissoires wrote:
    >> * amended Kconfig (PixCir and Hanvon are the same panel but with
    >>   different name)
    >> * insert field name in mt_class and retrieving it in mt_probe
    >> * add 2 quirks: MT_QUIRK_VALID_IS_INRANGE, MT_QUIRK_VALID_IS_CONFIDENCE,
    >>   in order to find the field "valid"
    >> * inlined slot_is_contactid and slot_is_contact_number
    >> * cosmetics changes (tabs and comments)
    >> * do not send unnecessary properties once the touch is up
    >>
    >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
    >
    > There are some syntactic suboptimalities in the resulting file that
    > perhaps could be fixed, but content-wise, I have nothing further. So,
    > given that it actually works,
    >
    > Acked-by: Henrik Rydberg <rydberg@euromail.se>
    >
    > Thank you very much for your work, Benjamin.

    Thanks for the review Henrik,

    Cheers,
    Benjamin
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-01-11 18:41    [W:0.022 / U:30.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site