lkml.org 
[lkml]   [2011]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] Cleanup include/net/tcp.h include-files and coding-style
    From
    On Mon, Jan 10, 2011 at 1:06 AM, Ben Hutchings
    <bhutchings@solarflare.com> wrote:
    > On Sun, 2011-01-09 at 23:33 +0100, Christoph Paasch wrote:

    >> > If a file directly references definitions that are supposed to be
    >> > provided by a certain header, changing it to rely on indirect inclusion
    >> > of that header generally does *not* aid maintenance.
    >> But then, to be coherent, we would need to add the following includes (and I'm
    >> even not 100% sure if it's all we need):
    >>
    >> linux/percpu_counter.h (needed for percpu_counter_sum_positive)
    >
    > Yes.

    Currently code compiles fine, so necessary headers are in place,
    so simply adding new headers doesn't help anything.

    >> linux/mm_types.h (needed for struct page)
    >> linux/aio.h (needed for struct kiocb)
    >> net/inet_sock.h (needed for struct ip_options)
    >> linux/pipe_fs_i.h (needed for struct pipe_inode_info)
    >> linux/poll.h (needed for struct poll_table_struct)
    >
    > Or declarations of those structs.
    >
    >> linux/compiler.h (needed for __percpu)
    > [...]
    >
    > Yes.


    \
     
     \ /
      Last update: 2011-01-10 12:13    [W:0.020 / U:0.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site