lkml.org 
[lkml]   [2011]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] x86: early_quirk check all dev/func in domain 0
On Mon, Jan 10, 2011 at 05:46:44PM -0800, Yinghai Lu wrote:
> On 01/10/2011 05:09 PM, Greg KH wrote:
> > On Mon, Jan 10, 2011 at 04:55:23PM -0800, Yinghai Lu wrote:
> >>
> >> go with all buses instead of bus0.
> >
> > Why?
>
> in cause USB host controller is not on Bus0.
>
> >
> >> also only check header type on func0.
> >
> > Why?
>
> that is bug.
>
> notice when there is 00:1a.0, 00:1a.1, 00:1a.2 00:1a.7
>
> the quirk code will not be applied with 00:1a.2 and 00:1a.7
>
> it will exit after checking 00:1a.1's header type.

Also, if this is a real bug, then just fix this in one patch, separate
from the other patches. Don't do more than one thing per patch.

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-01-11 04:43    [W:0.053 / U:2.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site